Allow an assert with a side effect
#1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntelliJ IDEA warns that this `assert` has side effects. In general, that's a likely bug because these effects would happen or not depending on the JVM's global `assert`-checking mode. However, in this _specific_ case, the possible side effect is safe, because `succs` is never subsequently used after the `assert`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1805 +/- ##
============================================
- Coverage 50.25% 50.24% -0.01%
Complexity 12657 12657
============================================
Files 1365 1365
Lines 85117 85117
Branches 14704 14704
============================================
- Hits 42774 42771 -3
- Misses 37548 37549 +1
- Partials 4795 4797 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msridhar
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ IDEA warns that this
asserthas side effects. In general, that's a likely bug because these effects would happen or not depending on the JVM's globalassert-checking mode. However, in this specific case, the possible side effect is safe, becausesuccsis never subsequently used after theassert.