Avoid redundant map lookups in cast/js/rhino
#1813
Merged
+13
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some redundant `Map` lookups, such as calling `containsKey` immediately before `get`. That's redundant as long as we never map to `null`, which appears to be the case for the maps we're modifying here. Also codify the existing `null`-avoidance policy for these maps by adding JSpecify annotations. It's not clear how thoroughly current tools check this annotation when used on a `Map`'s value type. But even if current tools don't check them, it's worth adding these annotations as documentation and (hopefully) as hints for future checkers.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1813 +/- ##
============================================
- Coverage 50.27% 50.26% -0.01%
+ Complexity 12658 12657 -1
============================================
Files 1365 1365
Lines 85091 85091
Branches 14682 14682
============================================
- Hits 42777 42774 -3
- Misses 37525 37526 +1
- Partials 4789 4791 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msridhar
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some redundant
Maplookups, such as callingcontainsKeyimmediately beforeget. That's redundant as long as we never map tonull, which appears to be the case for the maps we're modifying here.Also codify the existing
null-avoidance policy for these maps by adding JSpecify annotations. It's not clear how thoroughly current tools check this annotation when used on aMap's value type. But even if current tools don't check them, it's worth adding these annotations as documentation and (hopefully) as hints for future checkers.