[BugFix]: Fixed an issue with incorrectly counting the number of slot… #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommie
reviewed
Aug 3, 2024
| // OPTZ (memory): 'm3Slots' could still be fused with 'typeStack' if 4 bits were used to indicate: [0,1,2,many]. The many-case | ||
| // would scan 'wasmStack' to determine the actual usage count | ||
| if (o->m3Slots [i_slot] < 0xFF) | ||
| for (u16 i = 0; i < GetTypeNumSlots (i_type); ++i, ++i_slot) |
There was a problem hiding this comment.
I'd move the GetTypeNumSlots earlier, like what other functions do.
(It's a small function and it will be either 1 or 2, so no big deal.)
|
Is there a regression test for this? In what circumstances is it a problem? Since |
tommie
added a commit
to tommie/wasm3
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s used