-
Notifications
You must be signed in to change notification settings - Fork 1.6k
lws/mbedtls-openssl: Supplement x509 method structure implementation #3434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0e8400e to
e2c2b51
Compare
|
Well, with that on top it builds locally OK. I removed the old one from v4.4-stable, let's try this one in CI again with main |
very thanks. By the way, could I modify openssl interfaces wrappered by mbedtls? I understand that the original implementation is more in line with OpenSSL's implementation but loses the advantages of mbedtls. |
|
Originally there was a big difficulty implementing mbedtls support, because it is so different from openssl. So I borrowed the Espressif openssl wrapper (it's also MIT) to reduce the gulf. And we have been OK working like that. If there's something to gain we can consider it, but it's needed that we can still build with esp-idf (espresssif SDK). AFAIK we don't conflict or use the esp-idf original wrapper, just the one that is in-tree. AFAIK the wrapper is very light, but if there are advantages and nothing breaks, sure. |
Got it. We are maintaining the RTOS operating system NuttX, and we have also encountered many third-party libraries that use OpenSSL interfaces and require mbedtls as the backend implementation. We have also drawn on the Espressif SDK implementation, mainly modifying part of the dynamic memory usage, which will have certain advantages in IoT devices. |
|
@lws-team |
|
You can't pull main, it is developed by force-pushing. To update to it, for example (save any changes somewhere first) |
The client based on mbedtls backend does not implement the loading certificate from the default path, but the client based on openssl backend does. Signed-off-by: makejian <[email protected]>
Support interfaces SSL_CTX_load_verify_file/SSL_CTX_load_verify_dir/SSL_CTX_load_verify_locations to align with openssl-client behavior Signed-off-by: makejian <[email protected]>
e2c2b51 to
77ca1ca
Compare
|
@lws-team Thanks, i rebase my code and merged patch before. Please review |
|
Sorry, these are on top of current main? That tree already has your patches from yesterday These two patches are fixes, new features...? |
|
@lws-team Maybe I misunderstood. Let me confirm again: has this feature been merged into the main branch? |
|
@lws-team Oh, I've seen it on the main branch. Thanks again. |
5867044 to
3ee219e
Compare
f53e85a to
b1c0e74
Compare
acc64ac to
e50f2bd
Compare
efb9f35 to
1faedc3
Compare
721f91f to
49de3d2
Compare
a800d4a to
7f2f518
Compare
baf4897 to
0c7fa23
Compare
2b74af4 to
5f77374
Compare
a677221 to
0c67054
Compare
Additional commit #3432