Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add platform parameter for container import #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anderbubble merged 2 commits into from
Oct 29, 2024
Merged

add platform parameter for container import #1381

anderbubble merged 2 commits into from
Oct 29, 2024

Conversation

@mslacken
Copy link
Member

@mslacken mslacken commented Sep 5, 2024 •
edited by anderbubble
Loading

allows the download of a different arch than the arch warewulf is running on

  • The PR is based on the appropriate branch (typically main)
  • All commits are "Signed off" (e.g., using git commit --signoff) in agreement to the DCO
  • The CHANGELOG has been updated, if necessary, and under the correct release heading
  • The userdocs have been updated, if necessary
  • The submitter is listed in the contributors file
  • The test suite has been updated, if necessary

@anderbubble anderbubble added this to the v4.6.0 milestone Sep 5, 2024
@mslacken mslacken requested a review from anderbubble September 9, 2024 06:53
@anderbubble anderbubble self-assigned this Sep 9, 2024
@anderbubble
Copy link
Collaborator

anderbubble commented Oct 29, 2024

Rebased to main.

@anderbubble
Copy link
Collaborator

anderbubble commented Oct 29, 2024

Appears to work.

$ sudo wwctl container import docker://rockylinux/rockylinux:9 rockylinux-9-aarch64 --platform=arm64
Copying blob e193c3237353 done   | 
Copying config 27d7c42a0c done   | 
Writing manifest to image destination
2024/10/29 10:29:12  info unpack layer: sha256:e193c323735337ba59782f0e446c61987a732cb0a01da2cb2c8ac6948eb603e1

$ sudo wwctl container import docker://rockylinux/rockylinux:9 rockylinux-9-x86_64 --platform=amd64
Copying blob d037f40a474b done   | 
Copying config 3c8f8ff398 done   | 
Writing manifest to image destination
2024/10/29 10:29:26  info unpack layer: sha256:d037f40a474b143eb79b5188cc44670cad5f56378fa74a2dbfd07558c74a6361

$ file /var/lib/warewulf/chroots/rockylinux-9-aarch64/rootfs/bin/bash
/var/lib/warewulf/chroots/rockylinux-9-aarch64/rootfs/bin/bash: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, BuildID[sha1]=bedfc9d91b1d74995c8e19478125379bd2cadc76, for GNU/Linux 3.7.0, stripped

$ file /var/lib/warewulf/chroots/rockylinux-9-x86_64/rootfs/bin/bash
/var/lib/warewulf/chroots/rockylinux-9-x86_64/rootfs/bin/bash: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=ef892035f0f947ac78c4ef86ce9f30687fedc936, for GNU/Linux 3.2.0, stripped

@anderbubble
Copy link
Collaborator

anderbubble commented Oct 29, 2024

Adjusted CHANGELOG and added userdocs.

anderbubble
anderbubble approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@anderbubble anderbubble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wish there was a test; but there's no tests for container import yet, so I won't hold this PR to that standard.

@anderbubble anderbubble merged commit 5aba2b5 into warewulf:main Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anderbubble anderbubble anderbubble approved these changes

Assignees

@anderbubble anderbubble

Labels

None yet

Projects

None yet

Milestone

v4.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mslacken @anderbubble