20231029 clippy improvements #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soc Virnyl Estela <[email protected]>
Signed-off-by: Soc Virnyl Estela <[email protected]>
Member
|
Is there any way to enable lints globally and ignore particular lines or files selectively? |
Contributor
Author
I remember it's still an RFC 😭 but idk. The clippy.toml configuration option is still limited |
Member
|
If that's the case, it's a nack from me. Keeping them in sync will be a mess if things change and the general copy paste nature of this feels wasteful. If the situation of the rfc changes then I can consider this. If any other maintainer including Andreas would like to see this merged, feel free to drop an ack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for discussion. I haven't done real code edit yet to apply clippy suggestions as some parts of the code seems unlikely to have it applied.
CC: @AndreasBackx @Shinyzenith