Friendly cli #134
Merged
Friendly cli #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks great! Would you mind rebasing on main to avoid the conflicts? Apart from that the changes look great. Thank you once again for your help. |
Contributor
Author
|
Hello, @Shinyzenith ! I have merged conflicts, should be ready |
Shinyzenith
reviewed
Mar 19, 2025
Shinyzenith
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #104 rewriting, but mostly addresses #100 concerns.
Changes:
OUTPUT->FILEin order not to confuse output file and output (like, display one)listoutputs->list-outputschooseoutput->choose-outputswayshot/src/cli.rs/get_styles()list-outputstostdoutAs for tab completions, I suppose these are being working on in #132. I hope that one will introduce completions for
nuas well, though