-
-
Notifications
You must be signed in to change notification settings - Fork 38
feat: use libwaysip instead of slurp #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0c37c46 to
06623bc
Compare
06623bc to
5a4586b
Compare
bf20f56 to
5166fc1
Compare
|
What is the type |
It is just a name, describing the fun inside the enum, because clippy thought this type is too long, so I split it. Can you give me a better name? Thanks |
5166fc1 to
f830dc9
Compare
|
FreezeCallback sounds perfect |
|
Before merging we also need to do some documentation changes, I'll do that |
|
We're also going to need support for passing waysip args just how we pass slurp args |
|
Now that config file pr is merged, all relevant documentation places need to be changed |
Signed-off-by: Shinyzenith <[email protected]>
4620143 to
4cda7dc
Compare
rebase done |
|
Looks mostly good, just one doubt, don't we need to remove support for SLURP_ARGS from config file? @Decodetalkers |
Ha..yes , I have forgotten that, can you fix that for me? Thanks |
|
Sounds good, I'll do it |
|
Oh it seems like config file already doesn't accept SLURP_ARGS and that makes sense because that's supposed to be part of invocation. It's not meant to be present all the time. |
resolve: #1