Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add JPEG-XL encoding support #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Decodetalkers merged 8 commits into from
Dec 6, 2025
Merged

feat: add JPEG-XL encoding support #193

Decodetalkers merged 8 commits into from
Dec 6, 2025

Conversation

@Gigas002
Copy link
Contributor

@Gigas002 Gigas002 commented Jun 25, 2025

This PR introduces support for encoding jpeg-xl, closes #11.
Since there's no yet support for jxl in image-rs current version temporary uses jpegxl-rs crate.

Note, that since there's no rust-native jxl encoder, this crate adds dependency for libjxl. I think we may need to make this [feature] flag instead?

Also, there are some options available for controlling jxl encoder, such as lossless, quality, speed. We can make it configurable via config.toml file, though do we really need to go that far? Right now encoder uses default settings, which creates visualy lossless results.

One more thing to note, that this PR only adds ability for creating screenshot file as jxl, for now, at least. The clipboard and stdout result will be a simple jpeg. I am not sure if we should change this behavior, actually.

@Gigas002 Gigas002 changed the title JPEG-XL support feat: add JPEG-XL encoding support Jun 25, 2025
Shinyzenith
Shinyzenith previously approved these changes Aug 15, 2025
View reviewed changes
@EwoutH
Copy link

EwoutH commented Sep 22, 2025

What's the plan with this PR?

@Gigas002
Copy link
Contributor Author

Gigas002 commented Sep 23, 2025

@EwoutH
It's usable in its current state, except for clipboard screenshot.
I'm not sure it should be merged rn with this dirty workaround, but at the same time jxl support in image-rs isn't moving at all.
For now, you can use this pr as patch file and build from master branch, with this patch applied, if you want to use this feature.

@roland-5
Copy link

roland-5 commented Sep 26, 2025

image-rs/image#1765 and image-rs/image#1979 are closed. The image crate should now support jxl via the jxl-oxide crate, if I understand it corretly (image-rs/image#2372 and tirr-c/jxl-oxide#480)

@Gigas002
Copy link
Contributor Author

Gigas002 commented Sep 26, 2025

@roland-5 thanks, I'll check this out!

@Gigas002
Copy link
Contributor Author

Gigas002 commented Dec 2, 2025

Sorry it took a while for me to return to this PR, but I think it should work in all scenarios now.
Unfortunately, jxl-rs only have decoding support, so it doesn't make much sense to use it in our cases, so we have to depend on native libjxl installed on user's machines for now.

@Gigas002 Gigas002 marked this pull request as ready for review December 2, 2025 01:23
@Decodetalkers
Copy link
Collaborator

Decodetalkers commented Dec 2, 2025

ok, let us try this. @Shinyzenith what do you think of this pr?

@Decodetalkers Decodetalkers merged commit c49972c into waycrate:main Dec 6, 2025
4 checks passed
@Decodetalkers
Copy link
Collaborator

Decodetalkers commented Dec 6, 2025

ok, I think it should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Decodetalkers Decodetalkers Decodetalkers approved these changes

@Shinyzenith Shinyzenith Awaiting requested review from Shinyzenith

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support JPEG XL

5 participants

@Gigas002 @EwoutH @roland-5 @Decodetalkers @Shinyzenith