Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle gbm errors instead of panicking #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Decodetalkers merged 1 commit into from
Dec 18, 2025
Merged

Handle gbm errors instead of panicking #247

Decodetalkers merged 1 commit into from
Dec 18, 2025

Conversation

@dhruvDev23
Copy link
Contributor

@dhruvDev23 dhruvDev23 commented Dec 17, 2025

Fix potential panic in GBM device initialization

This PR prevents a potential panic in libwayshot when GBM device initialization fails.
The code previously used unwrap(), which would crash the program on error.

  • Replaced GBMDevice::new(gpu).unwrap() with GBMDevice::new(gpu)?
  • Allows the error to be returned to the caller instead of panicking.

@Decodetalkers Decodetalkers merged commit 7fe5497 into waycrate:main Dec 18, 2025
5 checks passed
@dhruvDev23 dhruvDev23 deleted the fix-gbm-panic branch December 18, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Decodetalkers Decodetalkers Decodetalkers approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvDev23 @Decodetalkers