Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@harshbrahmxatriya
Copy link
Contributor

@harshbrahmxatriya harshbrahmxatriya commented Feb 8, 2022

I have installed typography plugin and added it in tailwind.config.js file.
And you can test it on the profile page of a user, it should be visible right after the 'Welcome to WeDance!' line.
You can test it locally by switching to issue/127 branch and then yarn dev.
Deploy preview: https://6203ab6b4f017c00087232ed--wedance-harshbrahmxatriya.netlify.app/

@harshbrahmxatriya harshbrahmxatriya changed the base branch from main to beta February 8, 2022 18:01
Copy link
Contributor

@razbakov razbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. rebase your branch onto beta and make sure your pull request contains only your commits related to this issue
  2. there more places where class "typo" is used

@razbakov razbakov changed the title Replacing .typo css with typography plugin #127 chore: add tailwind typography plugin #127 Feb 8, 2022
@razbakov razbakov added the chore A tedious but necessary task label Feb 8, 2022
@harshbrahmxatriya
Copy link
Contributor Author

harshbrahmxatriya commented Feb 9, 2022

  1. rebase your branch onto beta and make sure your pull request contains only your commits related to this issue

    1. there more places where class "typo" is used

Actually, I have changed only one to look the change it does, now I have changed rest of the files.

@razbakov
Copy link
Contributor

Looks like deploy preview doesn't have code changes, see example here is still typo class.

@razbakov razbakov merged commit 3eabe98 into beta Feb 10, 2022
@razbakov razbakov deleted the issue/127 branch February 10, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A tedious but necessary task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants