fix: prevent numeric-only content hashes in filename templates #19897
+145
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using webpack filename templates with length-limited content hashes (e.g.,
[contenthash:12]), the hash truncation was performed using simple string slicing (hash.slice(0, length)). This could result in truncated hashes that contain only numeric characters, which can cause issues when RealContentHashPlugin try to replace the content hash with real content hash. #14058Root Cause
The
hashLengthfunction inTemplatedPathPlugin.jsused simple string slicing:When a hash like
"123456789101acbdefgh"was truncated to 12 characters, it could produce"123456789101"- a purely numeric string. This creates problems forRealContentHashPluginwhich expects to find and replace these hash patterns.Fix
Use existing
nonNumericOnlyHashutility function that webpack already uses internally: