fix: implement Object.defineProperty support in CommonJsExportRequireDependency #20004
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested changes
Oct 10, 2025
12 tasks
| <p>(In chronological order)</p> | ||
|
|
||
| - [@google](https://github.com/google) for [Google Web Toolkit (GWT)](http://www.gwtproject.org/), which aims to compile Java to JavaScript. It features a similar [Code Splitting](http://www.gwtproject.org/doc/latest/DevGuideCodeSplitting.html) as webpack. | ||
| - [@google](https://github.com/google) for [Google Web Toolkit (GWT)](http://www.gwtproject.org/), which aims to compile Java to JavaScript. It features a similar [Code Splitting](http://www.gwtproject.org/doc/latest/DevGuideCodeSplitting.html) to webpack. |
There was a problem hiding this comment.
Avoid this change, not related to fix
| } else { | ||
| ranges.push(`${quoteMeta(start)}-${quoteMeta(prev)}`); | ||
| } | ||
| return `[${ranges.join("")}]`; |
There was a problem hiding this comment.
Avoid this change, not related to fix
|
To be honest, I don’t think we currently support parsing reexport for |
|
@hai-x Lets keep this open until its fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements missing Object.defineProperty support in CommonJsExportRequireDependency, fixing a TODO that threw runtime errors.
Changes:
throw new Error("TODO")with proper Object.defineProperty implementationWhat kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?