Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to cut down on number of Meteor packages to ease migration
https://github.com/mquandalle/meteor-mousetrap-bindglobal
https://github.com/mquandalle/meteor-jquery-textcomplete
I opted to replace these with https://github.com/jaywcjlove/hotkeys-js and https://github.com/yuku/textcomplete
https://github.com/yuku/textcomplete is a bit outdated but I chose it because implementing a native solution would be ~150 lines or more which is a bit of a burden for a solor developer like @xet7
hotkeys-js had to be downgraded to 3.13.15 as regular imports weren't working v4