Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(pod): 为ResourceUsageTable添加denom参数支持 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weibaohui merged 1 commit into from
Nov 22, 2025
Merged

fix(pod): 为ResourceUsageTable添加denom参数支持 #73

weibaohui merged 1 commit into from
Nov 22, 2025

Conversation

@weibaohui
Copy link
Owner

@weibaohui weibaohui commented Nov 22, 2025

ResourceUsageTable函数现在支持传递denom参数，以保持与ResourceUsage函数的一致性

@weibaohui
fix(pod): 为ResourceUsageTable添加denom参数支持
d243d54 
ResourceUsageTable函数现在支持传递denom参数，以保持与ResourceUsage函数的一致性
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

发布说明

  • 重构
    • 优化了资源使用统计表的生成机制，支持灵活的计量单位配置。

✏️ Tip: You can customize this high-level summary in your review settings.

概览

ResourceUsageTable 方法签名更新为接收可变参数 denom ...UsageDenominator，并将其转发至 ResourceUsage 调用。mcp/tools/pod/usage.go 中的 ResourceUsage 调用现在传递 kom.DenominatorLimit 参数，实现配置化分母支持。

变更

聚类 / 文件 变更摘要
Pod 用量表接口更新
kom/ctl_pod_usage.go		 ResourceUsageTable() 方法签名扩展为支持可变参数 denom ...UsageDenominator，并将该参数转发给 ResourceUsage() 调用，使表生成的分母配置可控制。
用量数据查询调用点更新
mcp/tools/pod/usage.go		 Pod().ResourceUsage() 调用更新为 Pod().ResourceUsage(kom.DenominatorLimit)，显式传递分母限制参数以影响用量数据计算。

估计代码审查工作量

🎯 2 (简单) | ⏱️ ~8 分钟

  • 注意 ResourceUsageTable 的新可变参数 denom 是否在所有调用点正确处理
  • 验证 kom.DenominatorLimit 是否为有效的分母值并符合预期的语义

相关的 PR

诗

🐰 参数悄然化变通，
分母纳入传递中，
灵动的小箭函数，
如今更显魔力深，
配置灵活任我控！

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch realtime
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbcada7 and d243d54.

📒 Files selected for processing (2)
  • kom/ctl_pod_usage.go (1 hunks)
  • mcp/tools/pod/usage.go (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weibaohui weibaohui merged commit 5dc2dda into main Nov 22, 2025
5 of 6 checks passed
@weibaohui weibaohui deleted the realtime branch November 22, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weibaohui