New function to efficiently remove the last entries from an archive #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for providing this PR. I like the idea of using truncate as fast-path when possible but I wonder if it wouldn't be better to keep that an implementation detail. |
added 2 commits
May 23, 2025 15:49
… into development
With support for efficient truncation when removed entries are contiguous at the end of the archive.
|
It took a while, but I've implemented your suggestion in the pull request: I've added a function for removing multiple entries from an archive (this fixes #109), with a fast-path for truncation if the entries to remove are contiguous at the end of the archive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
In this pull request, I added a new function for incrementally removing the last entries from an archive. This is very handy, when you want to remove and re-add entries add the end of an archive as you don't have to rewrite the archive in full.
The function is: Archive.removeAllEntries(fromEntry entry: Entry)
Tests performed
I implemented trhee tests for the function following the existing test pattern.