-
-
Notifications
You must be signed in to change notification settings - Fork 79
🐛 fix: support external URLs in menu #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
This was referenced Feb 3, 2025
This was referenced Feb 10, 2025
This was referenced Feb 17, 2025
This was referenced Feb 24, 2025
This was referenced Mar 3, 2025
This was referenced Mar 17, 2025
This was referenced Mar 24, 2025
This was referenced Mar 31, 2025
This was referenced Apr 14, 2025
This was referenced Apr 21, 2025
This was referenced May 5, 2025
This was referenced May 12, 2025
This was referenced May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix navigation menu handling of external URLs and update documentation to clarify external URL support.
Related issue
Fixes #480
Changes
This PR fixes a bug where external URLs in the navigation menu were being treated as relative URLs, resulting in incorrect paths like
http://127.0.0.1:1111/https://example.com/. The fix:get_url()This implements the same fix that was previously applied to the footer menu (#212).
Type of change
Checklist
theme.tomlwith a sane default for the featureconfig.tomlin tabi-startconfig.tomlcommentstheme.tomlcomments