This repository was archived by the owner on Sep 20, 2025. It is now read-only.
Corrected typo, set Compiler to 90% #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a percentage sign and I think 'no Windows support' weights more as 1% Spelling that a compiler is 99% ready with zero support for this one OS might seem a little bit like discrimination? Wonderful to see how this overview about your progress grows, I absolutely love it ^-^
wende
suggested changes
Apr 9, 2018
README.md
Outdated
| - Parser - **99%** of Elm's syntax (see [elm-ast](https://github.com/Bogdanp/elm-ast/issues)) | ||
| - Compiler - **99%** (Sophisticated incremental compilation. No support for Windows yet though ([#287](https://github.com/wende/elchemy/issues/287)) also big reliance on unix tools ([#288](https://github.com/wende/elchemy/issues/288)) | ||
| - Elchemy-core - **95** ( Everything covered except side effects and JSON Decoders) | ||
| - Compiler - **90%** (Sophisticated incremental compilation. No support for Windows yet though ([#287](https://github.com/wende/elchemy/issues287)) also big reliance on unix tools ([#288](https://github.com/wende/elchemy/issues/288)) |
There was a problem hiding this comment.
The second change breaks the link. Plus it is obviously arguable, but I don't consider out of the box windows support as a compiler feature
There was a problem hiding this comment.
Well, you mention it a few characters next to the percentage, so it suggests that you see it so?
I fixed the link, good catch ;)
wende
approved these changes
Apr 9, 2018
|
LGTM 👍 |
|
Is this LGTM supposed to trigger the merge? |
wende
added a commit
that referenced
this pull request
May 16, 2018
================ * Closes #276 macro plugins (#331) * Update elm-package.json * Bug: Closes #327 (#328) * Closes #329 - Warn when elchemy not installed during project compilation (#330) * Closes #238 - Debug.log print in Elchemy format instead of Elixir format (#325) * Closes #322 Warn when elchemy line put incorrectly (#323) * Update README.md (#320) * correct typos (#318) * type savety and Elixir (#310) * Closes #313 Fixes interop in gitbook and new gitbbok (#317) * Corrected typo, set Compiler to 90% (#314) * Corrected typo (#306) * Corrected typos (#307) * correct typo (#308) * Delete FEATURES.MD * Create CODE_OF_CONDUCT.md (#304) * Typo in gitbook (#305) * 0.6.6 / 2018-03-05 ================ * 0.6.6 * format properly * 0.6.5 / 2018-03-05 ================ * 0.6.5 * format when > 1.6.0 (#300) * Update README.md * Better references in maturity of the project summary * Update SIDE_EFFECTS.md * Update SUMMARY.md * Update SUMMARY.md * Add SYNTAX OVERVIEW * Create SYNTAX.md * Fix to 292 (#293) * Closes #290 - incremental compiler bug (#291) * 0.6.4 / 2018-02-07 ================ * 0.6.4 * Updated core
wende
added a commit
that referenced
this pull request
May 23, 2018
================ * Clean makes init not able to work (#341) * No project name (#339) * Correct typos in roadmap/STRUCTURES.md (#319) * Added formating and test (#337) * 0.7.2 / 2018-05-16 ================ * 0.7.2 * Closes #276 macro plugins (#331) * Update elm-package.json * Bug: Closes #327 (#328) * Closes #329 - Warn when elchemy not installed during project compilation (#330) * Closes #238 - Debug.log print in Elchemy format instead of Elixir format (#325) * Closes #322 Warn when elchemy line put incorrectly (#323) * Update README.md (#320) * correct typos (#318) * type savety and Elixir (#310) * Closes #313 Fixes interop in gitbook and new gitbbok (#317) * Corrected typo, set Compiler to 90% (#314) * Corrected typo (#306) * Corrected typos (#307) * correct typo (#308) * Delete FEATURES.MD * Create CODE_OF_CONDUCT.md (#304) * Typo in gitbook (#305) * 0.6.6 / 2018-03-05 ================ * 0.6.6 * format properly * 0.6.5 / 2018-03-05 ================ * 0.6.5 * format when > 1.6.0 (#300) * Update README.md * Better references in maturity of the project summary * Update SIDE_EFFECTS.md * Update SUMMARY.md * Update SUMMARY.md * Add SYNTAX OVERVIEW * Create SYNTAX.md * Fix to 292 (#293) * Closes #290 - incremental compiler bug (#291) * 0.6.4 / 2018-02-07 ================ * 0.6.4 * Updated core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a percentage sign to the Elchemy-core support.
So this also changes the percentage support for the compiler to 90% since no Windows support weights probably more as 1% in practically everybody's opinion.
Wonderful to see how this overview about your progress grows, I absolutely love it ^-^