Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

BrahimMahadi
Copy link
Contributor

What does this pull request (PR) do?

This pull request includes the WCAG 2.1 & 2.2 Accessibility assessments done for the overlay plugin

General checklist

  • Updated overlay documentation to include the accessibility assessment reports
  • Plugin was tested against WCAG for accessibility
  • Documentation is bilingual

Copy link
Contributor

@Ricokola Ricokola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left comments for some things to review and discuss with @duboisp

}

]' href="#" lang="en"><span lang="fr">Non Définie</span></a></dd>
<dt>Subject</dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should we used the French term: "Sujet" instead?
  • In terms of the output, it's stated: "Evaluated all Success Criteria at Level AA of WCAG 2.2"...is this statement should mentioned that it's evaluated against criteria Level AA of WCAG 2.0, 2.1 and 2.2?
  • IS there any French translation for the output message?

<dd data-json-replace="#[a11y]/assessment" lang="en"><span lang="fr">Non Définie</span></dd>
<dt>Notes:</dt>
<dd data-json-replace="#[a11y]/notes" lang="en"><span lang="fr">Aucune note</span></dd>
<dt>Scores</dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we used the French term: "Marque" instead?

<dd data-json-replace="#[a11y]/assessment">Not Defined</dd>
<dt>Notes:</dt>
<dd data-json-replace="#[a11y]/notes">No notes</dd>
<dt>Scores</dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is only one final percentage, should we write "Score" singular without an "s" ate the end?

}

]' href="#">Not Defined</a></dd>
<dt>Subject</dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of the output, it's stated: "Evaluated all Success Criteria at Level AA of WCAG 2.2"...is this statement should mentioned that it's evaluated against success criteria Level AA of WCAG 2.0, 2.1 and 2.2?

@duboisp duboisp assigned BrahimMahadi and unassigned Ricokola May 24, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrahimMahadi please update your assessment according to the new methodologies and the revised vocabulary terms.

@duboisp duboisp added the Query: Project item Support a github project label Sep 21, 2023
@duboisp
Copy link
Member

duboisp commented Feb 12, 2024

FYI - @HeansiH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Query: Project item Support a github project

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants