Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@EricDunsworth
Copy link
Member

@EricDunsworth EricDunsworth commented Sep 1, 2023

WIP

Specifically:

  • Borders:
    • border-top-0
    • border-bottom-0
  • Color scheme:
    • text-black (5.1)
  • Flexbox:
    • d-md-flex
    • flex-sm-column
    • flex-sm-grow-1 (4.1)
    • flex-md-column
    • flex-md-grow-1 (4.1)
    • flex-md-wrap
    • flex-wrap
  • Shadows:
    • shadow-none (4.1)

Notes:

  • FR typo fix
  • col-xs-12 class name typo fixes in flex-sm-wrap examples
  • Some backported classes are from newer versions of Bootstrap than 4.0
  • Used !important in classes tied to common CSS properties
    • Omitted it from classes tied to uncommon properties (e.g. property names containing "flex") or where precents existed (e.g. d-sm-flex didn't use !important in its display property... so d-md-flex won't either)
  • The backported text-black class is inconsistent with WET's implementation of text-white:
    • text-black uses !important... text-white doesn't
    • text-white contains link and button colour overrides... text-black doesn't (Bootstrap 4 has no solution for this, 5 uses link-* classes)
    • text-black is more in line with Bootstrap's version than WET's version of text-white

Specifically:
* Borders:
  * border-top-0
  * border-bottom-0
* Color scheme:
  * text-black (5.1)
* Flexbox:
  * d-md-flex
  * flex-sm-column
  * flex-sm-grow-1 (4.1)
  * flex-md-column
  * flex-md-grow-1 (4.1)
  * flex-md-wrap
  * flex-wrap
* Shadows:
  * shadow-none (4.1)

Notes:
* FR typo fix
* col-xs-12 class name typo fixes in flex-sm-wrap examples
* Some backported classes are from newer versions of Bootstrap than 4.0
* Used !important in classes tied to common CSS properties
  * Omitted it from classes tied to uncommon properties (e.g. property names containing "flex") or where precents existed (e.g. d-sm-flex didn't use !important in its display property... so d-md-flex won't either)
* The backported text-black class is inconsistent with WET's implementation of text-white:
  * text-black uses !important... text-white doesn't
  * text-white contains link and button colour overrides... text-black doesn't (Bootstrap 4 has no solution for this, 5 uses link-* classes)
  * text-black is more in line with Bootstrap's version than WET's version of text-white
@EricDunsworth EricDunsworth force-pushed the v4.0-bootstrap4-backports-borders-color-flexbox-shadows branch from 45987ec to 9376d3f Compare September 1, 2023 17:37
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricDunsworth may be during one of our weekly office hours, can you show us your department use case which would require leverage those new CSS backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants