feat: add extensions support for WebAuthnP256.sign #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
requested changes
May 1, 2025
Contributor
Author
|
Thanks @tmm for the review - applied all suggestions and updated |
Contributor
Author
|
Hi @tmm! Whenever you have a moment, could you take a look at my PR? Let me know if you'd like any changes and I'll get them sorted. Thanks! |
|
@tmm is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extensions support for
WebAuthnP256.sign, similar toWebAuthnP256.createCredentialChanged
extensionbehavior ingetCredentialCreationOptionsWhy it’s important?
WebAuthnP256.createCredentialalready supports extensions