Rename response processing algorithms #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this renames processResponseEndOfBody/process response end-of-body to processResponseConsumeBody/process response consume body and processResponseDone/process response done to processResponseEndOfBody/process response end-of-body. Apologies for the confusion this may cause.
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Dec 13, 2021
(The old) processResponseEndOfBody is now processResponseConsumeBody. See whatwg/fetch#1369 for context.
This was referenced Dec 13, 2021
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Dec 13, 2021
(The old) processResponseEndOfBody is now processResponseConsumeBody. See whatwg/fetch#1369 for context.
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Dec 14, 2021
(The old) processResponseEndOfBody is now processResponseConsumeBody. See whatwg/fetch#1369 for context. Closes #7417.
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
(The old) processResponseEndOfBody is now processResponseConsumeBody. See whatwg/fetch#1369 for context. Closes whatwg#7417.
Bishwarupjee
pushed a commit
to Bishwarupjee/xhr
that referenced
this pull request
Jan 31, 2024
(The old) processResponseEndOfBody is now processResponseConsumeBody. See whatwg/fetch#1369 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this renames processResponseEndOfBody/process response end-of-body to processResponseConsumeBody/process response consume body and processResponseDone/process response done to processResponseEndOfBody/process response end-of-body.
Apologies for the confusion this may cause.
@noamr I went for these names after all as "end-of-body" seemed clearer than "flush" in relation to "response". (If using "flush" we'd have to rename "process request end-of-body" as well.)
Preview | Diff