Fix/insights edge cases #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
jinyoungbang
approved these changes
Feb 18, 2024
Contributor
jinyoungbang
left a comment
There was a problem hiding this comment.
Overall, looks great! Just have a minor feedback in data consistency and one of the JSON files but once you fix that, I think we should be good to go :)
Ideally, client should see a null value and based off of that, render a value properly.
| if count_gpa: | ||
| avg_gpa /= count_gpa | ||
| else: | ||
| avg_gpa = "N/A" |
Contributor
There was a problem hiding this comment.
I think using None is a better choice instead of using strings – having multiple datatypes being returned isn't too good of a practice
| @@ -0,0 +1 @@ | |||
| [] No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I don't think it's necessary to create this! In the fixture itself, you can always check for an empty array instead of loading a file and reading it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Had to fix some issues in backend handling edge cases for insights (e.g. missing applicants, no gpas, no gradYears, no majors). Added unit tests for
missing applicantsandmissing gpas(the others aren't testable right now because there are frontend restrictions that guarantee inclusion of gradYear and major for everyone.Type of change
Tests Performed
Created new unit tests via
pytestformissing applicantsandmissing gpasScreenshots
Additional Comments