feat: Implement Route Protection through JWT #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
szou00
reviewed
Mar 7, 2024
chalicelib/decorators.py
Outdated
| Args: | ||
| blueprint (object): The Chalice Blueprint object, providing access to the current request. | ||
| role (list[str]): The required role for authorization. |
There was a problem hiding this comment.
should 'role' in the args description be plural ?
There was a problem hiding this comment.
i did not know decorator functions was a thing ... very cool and useful 👍
Contributor
Author
There was a problem hiding this comment.
should be roles 🥲
szou00
reviewed
Mar 7, 2024
| )["Parameter"]["Value"] | ||
| decoded = jwt.decode(token, auth_secret, algorithms=["HS256"]) | ||
| print(roles) | ||
| # TODO: if decoded role is not part of given, reject auth |
There was a problem hiding this comment.
omg i thought i was being silly bc i couldn't figure out where u were actually doing something with the roles but looks like it's a to-do. i'm assuming you're probably going to finish this up and i'll do another review (to my ability) when u r done ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Tests Performed
Screenshots
Additional Comments