Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Integrate Sentry into Zap #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jinyoungbang merged 2 commits into from
Jul 2, 2024
Merged

feat: Integrate Sentry into Zap #77

jinyoungbang merged 2 commits into from
Jul 2, 2024

Conversation

@jinyoungbang
Copy link
Contributor

@jinyoungbang jinyoungbang commented Jun 29, 2024 •
edited
Loading

What does this PR do?

  • Integrates Sentry into Zap for error tracing and observability purposes.

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

  • Environment splitting
  • Manual error testing

Screenshots

Screenshot 2024-06-29 at 6 37 04 PM Screenshot 2024-06-29 at 6 52 14 PM

Additional Comments

@github-actions
Copy link

github-actions bot commented Jun 29, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1565 1106 71% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
app.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 80bbcdb by action🐍

wderocco8
wderocco8 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@wderocco8 wderocco8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinyoungbang jinyoungbang merged commit 1d34eb4 into dev/v1.0 Jul 2, 2024
@jinyoungbang jinyoungbang deleted the feat/sentry branch July 2, 2024 01:46
@jinyoungbang jinyoungbang added the feature New Features label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wderocco8 wderocco8 wderocco8 approved these changes

@chrischo360 chrischo360 Awaiting requested review from chrischo360

@szou00 szou00 Awaiting requested review from szou00

@ojnim ojnim Awaiting requested review from ojnim

Assignees

No one assigned

Labels

feature New Features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinyoungbang @wderocco8