added boilerplate for update_many_documents + modify_rush_settings (and added some API unittests for events)
#79
Conversation
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
jinyoungbang
left a comment
There was a problem hiding this comment.
See the comments and would love to see the reasoning behind the string null – apart from that, LGTM! Let's merge after I understand the design choice behind it.
chalicelib/api/events.py
Outdated
| @events_api.route("/events/rush/settings/{default_rush_category_id}", methods=["PATCH"], cors=True) | ||
| @auth(events_api, roles=["admin"]) | ||
| def modify_rush_settings(default_rush_category_id): | ||
| if default_rush_category_id == "null": |
There was a problem hiding this comment.
Could the string null ever popup?
chalicelib/modules/mongo.py
Outdated
| return False | ||
|
|
||
| @add_env_suffix | ||
| def update_many_documents(self, collection: str, filter_query: dict, update_query: dict, array_filters=None): |
There was a problem hiding this comment.
def update_many_documents(self, collection: str, filter_query: dict, update_query: dict, array_filters=None): -> dict
You could also potentially typecast the return value too
Lowkey I agree. I initially passed |
… dynamodb to fail)
events)
What does this PR do?
Added necessary backend changes to support frontend PR. This involved:
update_many_documentsfunction inside ofMongoModulemodify_rush_settingscalled by/events/rush/settings/{default_rush_category_id}API endpointType of change
Tests Performed
Screenshots
Additional Comments