Fix/add mongomock unittests #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
jinyoungbang
approved these changes
Jul 14, 2024
Contributor
jinyoungbang
left a comment
There was a problem hiding this comment.
LGTM! Maybe make that one change that I commented. Thank you for the unit tests :)
Contributor
There was a problem hiding this comment.
Consider using a ternary operator!
def __init__(self, use_mock=False):
"""Establishes connection to MongoDB server"""
self.mongo_client = mongomock.MongoClient() if use_mock else MongoClient(self.uri)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added more unit tests to the backend and integrated support for MongoDB testing with
mongomocklibrary.Type of change
Tests Performed
Screenshots
Additional Comments