Thanks to visit codestin.com
Credit goes to github.com

Skip to content

patched bug not being able to update event #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wderocco8 merged 1 commit into from
Jul 20, 2024
Merged

patched bug not being able to update event #91

wderocco8 merged 1 commit into from
Jul 20, 2024

Conversation

@wderocco8
Copy link
Member

@wderocco8 wderocco8 commented Jul 20, 2024 •
edited
Loading

What does this PR do?

Fixed bug not being able to persist updates for rush events to the category document.

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@wderocco8 wderocco8 added the fix label Jul 20, 2024
@wderocco8 wderocco8 requested a review from jinyoungbang July 20, 2024 21:31
@github-actions
Copy link

github-actions bot commented Jul 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1835 1359 74% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/services/EventService.py 24% 🟢
TOTAL 24% 🟢

updated for commit: 4f2786d by action🐍

jinyoungbang
jinyoungbang approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wderocco8 wderocco8 merged commit 6c8412c into dev/v1.0 Jul 20, 2024
@wderocco8 wderocco8 deleted the fix/modify-rush-event-persist branch July 20, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinyoungbang jinyoungbang jinyoungbang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wderocco8 @jinyoungbang