Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wderocco8
Copy link
Member

What does this PR do?

Patched bug where event won't delete

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@wderocco8 wderocco8 added the fix label Jul 20, 2024
@wderocco8 wderocco8 requested a review from jinyoungbang July 20, 2024 22:41
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1842 1359 74% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/services/EventService.py 23% 🟢
TOTAL 23% 🟢

updated for commit: ee07dbd by action🐍

Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hear me out – so we'd need these data in the case that admins/members would want to see stats or people who signed in for the events. I think it'd make sense to have like a flag on the service side where it can be a trigger to pop or keep the items inside. Then, we could have two separate APIs (one with auth that does not trigger the flag to hide data and the other being public with sensitive data being popped out).

Let me know what you think!

@jinyoungbang jinyoungbang self-requested a review July 21, 2024 16:41
@wderocco8 wderocco8 merged commit 9948d73 into dev/v1.0 Jul 21, 2024
@wderocco8 wderocco8 deleted the fix/delete-rush-event-bug branch July 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants