Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor/split event service and split attendees into separate collection #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wderocco8 merged 5 commits into from
Jul 22, 2024
Merged

Refactor/split event service and split attendees into separate collection #93

wderocco8 merged 5 commits into from
Jul 22, 2024

Conversation

@wderocco8
Copy link
Member

@wderocco8 wderocco8 commented Jul 21, 2024

What does this PR do?

Separates EventService into EventsMemberService and EventsRushService (along with the associated API and test changes).

Creates separate events-rush-event-attendees collection to store attendee info (which will make updates very quick when rushees check into an event)

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@wderocco8 wderocco8 added the refactor Code Refactor label Jul 21, 2024
@wderocco8 wderocco8 requested a review from jinyoungbang July 21, 2024 19:49
@github-actions
Copy link

github-actions bot commented Jul 21, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1867 1381 74% 70% 🟢

New Files

File Coverage Status
chalicelib/api/events_member.py 96% 🟢
chalicelib/api/events_rush.py 100% 🟢
chalicelib/services/EventsMemberService.py 40% 🟢
chalicelib/services/EventsRushService.py 18% 🟢
tests/api/test_events_members.py 100% 🟢
tests/api/test_events_rush.py 100% 🟢
TOTAL 76% 🟢

Modified Files

File Coverage Status
app.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 46087fe by action🐍

jinyoungbang
jinyoungbang approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the refactoring!

@wderocco8 wderocco8 merged commit bcd188c into dev/v1.0 Jul 22, 2024
@wderocco8 wderocco8 deleted the refactor/split-event-service-and-auth-flagged-api branch July 22, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinyoungbang jinyoungbang jinyoungbang approved these changes

Assignees

No one assigned

Labels

refactor Code Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wderocco8 @jinyoungbang