Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wderocco8
Copy link
Member

What does this PR do?

Added support for getting rush events to rushee dashboard.

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@wderocco8 wderocco8 requested a review from jinyoungbang July 25, 2024 02:27
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1876 1384 74% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/api/events_rush.py 98% 🟢
chalicelib/modules/mongo.py 25% 🟢
chalicelib/services/EventsMemberService.py 40% 🟢
chalicelib/services/EventsRushService.py 17% 🟢
chalicelib/services/MemberService.py 44% 🟢
tests/services/test_events_member_service.py 100% 🟢
TOTAL 54% 🟢

updated for commit: 04e8c5d by action🐍

Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just see the one comment I posted and please follow-up on it!

@jinyoungbang jinyoungbang merged commit 6a0e81f into dev/v1.0 Jul 25, 2024
@jinyoungbang jinyoungbang deleted the feat/rush_dashboard_ZAP branch July 25, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants