Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wderocco8
Copy link
Member

@wderocco8 wderocco8 commented Jul 25, 2024

What does this PR do?

Reverted attendees back to an embedded approach (this will make it much faster to query information like whether or not a rush has attended an event). Also added to API to return checkedIn status.

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@wderocco8 wderocco8 requested a review from jinyoungbang July 25, 2024 23:07
@github-actions
Copy link

github-actions bot commented Jul 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1884 1384 73% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/api/events_rush.py 95% 🟢
chalicelib/services/EventsRushService.py 17% 🟢
TOTAL 56% 🟢

updated for commit: ee59136 by action🐍

Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments but should be a quick fix – regardless, great job 👍 !!

@jinyoungbang jinyoungbang self-requested a review July 26, 2024 01:08
@wderocco8 wderocco8 merged commit f4a7523 into dev/v1.0 Jul 26, 2024
@wderocco8 wderocco8 deleted the refactor/applicants-embedded branch July 26, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants