Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: implement family tree get filter api #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jinyoungbang merged 1 commit into from
Aug 4, 2024
Merged

feat: implement family tree get filter api #99

jinyoungbang merged 1 commit into from
Aug 4, 2024

Conversation

@jinyoungbang
Copy link
Contributor

@jinyoungbang jinyoungbang commented Aug 4, 2024 •
edited
Loading

What does this PR do?

  • Created an API that structures data for family tree creation in client-side

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@github-actions
Copy link

github-actions bot commented Aug 4, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2024 1500 74% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/api/members.py 98% 🟢
chalicelib/services/MemberService.py 33% 🟢
TOTAL 66% 🟢

updated for commit: 3271fe4 by action🐍

@jinyoungbang jinyoungbang added the feature New Features label Aug 4, 2024
wderocco8
wderocco8 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Member

@wderocco8 wderocco8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinyoungbang jinyoungbang merged commit 47f62a5 into dev/v1.0 Aug 4, 2024
@jinyoungbang jinyoungbang deleted the feat/family-tree branch August 4, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wderocco8 wderocco8 wderocco8 approved these changes

@yoontsy2000 yoontsy2000 Awaiting requested review from yoontsy2000

Assignees

No one assigned

Labels

feature New Features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinyoungbang @wderocco8