feat: Implement Visibility Toggle API #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoontsy2000
reviewed
Nov 12, 2023
ojnim
reviewed
Nov 12, 2023
cwgough
reviewed
Nov 17, 2023
cwgough
reviewed
Nov 17, 2023
cwgough
requested changes
Nov 17, 2023
cwgough
left a comment
There was a problem hiding this comment.
See comments. Additionally I'll add that the wording of the PR itself is a little unclear: is the listing visible to all users, or just brothers, or just applicants? Just a bullet about the use case might be helpful so we know why the change is necessary as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#3
Listingobjects in DynamoDBType of change
Tests Performed
Manual testing (tested success and error cases)
Screenshots
Additional Comments