Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Listings API Code Cleanups #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wderocco8 merged 7 commits into from
May 21, 2025
Merged

chore: Listings API Code Cleanups #135

wderocco8 merged 7 commits into from
May 21, 2025

Conversation

@jinyoungbang
Copy link
Contributor

@jinyoungbang jinyoungbang commented May 17, 2025 •
edited
Loading

What does this PR do?

  • Error handling decorator was never getting triggered, thus always returning 200 success code / fixed usage and corresponding unit tests
  • Better error handling for debugging and observability purposes

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@github-actions
Copy link

github-actions bot commented May 17, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2544 1942 76% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/api/listings.py 98% 🟢
chalicelib/handlers/error_handler.py 100% 🟢
chalicelib/services/EventsMemberService.py 38% 🟢
chalicelib/services/ListingService.py 71% 🟢
tests/api/test_listings.py 100% 🟢
tests/services/test_listing_service.py 100% 🟢
tests/test_decorators.py 100% 🟢
TOTAL 87% 🟢

updated for commit: 0ffae26 by action🐍

@jinyoungbang jinyoungbang changed the title chore: Code Cleanups chore: Listings API Code Cleanups May 17, 2025
@jinyoungbang jinyoungbang marked this pull request as ready for review May 17, 2025 14:59
wderocco8
wderocco8 approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@wderocco8 wderocco8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wderocco8 wderocco8 merged commit 40f6cb4 into dev/v3.0 May 21, 2025
1 check passed
@wderocco8 wderocco8 deleted the chore/code-cleanup branch May 21, 2025 04:27
@jinyoungbang jinyoungbang added the improvement Enhancements label Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wderocco8 wderocco8 wderocco8 approved these changes

@vinli0921 vinli0921 Awaiting requested review from vinli0921

@MattFromBeijing MattFromBeijing Awaiting requested review from MattFromBeijing

Assignees

No one assigned

Labels

improvement Enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinyoungbang @wderocco8