Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore/will/pylance types #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wderocco8 merged 4 commits into from
May 21, 2025
Merged

Chore/will/pylance types #138

wderocco8 merged 4 commits into from
May 21, 2025

Conversation

@wderocco8
Copy link
Member

@wderocco8 wderocco8 commented May 21, 2025

What does this PR do?

Cleaned up typing imports and definitions across the codebase.

I realized that I've been using the Pylance VSCode extension, but the Type Checking Mode was set to off (the default). I'd recommend setting it to standard which will help us catch more potential errors earlier (and help with intellisense).

Should be a fairly small change, but I believe it will help a lot in the long run.

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Ran pytests

Screensh

Screenshot 2025-05-20 at 7 14 14 PM Screenshot 2025-05-21 at 10 32 48 AM ots

Additional Comments

@jinyoungbang jinyoungbang changed the base branch from main to dev/v3.0 May 21, 2025 15:13
@wderocco8 wderocco8 closed this May 21, 2025
@github-actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2544 1942 76% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
app.py 100% 🟢
chalicelib/api/accountability.py 62% 🟢
chalicelib/api/applicants.py 100% 🟢
chalicelib/api/broadcast.py 43% 🟢
chalicelib/api/events_member.py 96% 🟢
chalicelib/api/events_rush.py 94% 🟢
chalicelib/api/insights.py 100% 🟢
chalicelib/api/listings.py 98% 🟢
chalicelib/api/members.py 98% 🟢
chalicelib/api/monitoring.py 89% 🟢
chalicelib/decorators.py 100% 🟢
chalicelib/events/test.py 100% 🟢
chalicelib/handlers/error_handler.py 100% 🟢
chalicelib/services/AccountabilityService.py 47% 🟢
chalicelib/services/ApplicantService.py 67% 🟢
chalicelib/services/EventsMemberService.py 38% 🟢
chalicelib/services/EventsRushService.py 15% 🟢
chalicelib/services/ListingService.py 71% 🟢
chalicelib/services/MemberService.py 33% 🟢
tests/api/test_listings.py 100% 🟢
TOTAL 78% 🟢

updated for commit: 3471bcb by action🐍

@wderocco8 wderocco8 reopened this May 21, 2025
jinyoungbang
jinyoungbang approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wderocco8 wderocco8 merged commit d194663 into dev/v3.0 May 21, 2025
2 checks passed
@wderocco8 wderocco8 deleted the chore/will/pylance-types branch May 21, 2025 15:22
@jinyoungbang jinyoungbang added the improvement Enhancements label Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinyoungbang jinyoungbang jinyoungbang approved these changes

@vinli0921 vinli0921 Awaiting requested review from vinli0921

@MattFromBeijing MattFromBeijing Awaiting requested review from MattFromBeijing

Assignees

No one assigned

Labels

improvement Enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wderocco8 @jinyoungbang