Thanks to visit codestin.com
Credit goes to github.com

Skip to content

merge: v0.2 beta to staging #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jinyoungbang merged 29 commits into from
Jan 23, 2024
Merged

merge: v0.2 beta to staging #25

jinyoungbang merged 29 commits into from
Jan 23, 2024

Conversation

@jinyoungbang
Copy link
Contributor

@jinyoungbang jinyoungbang commented Jan 23, 2024

What does this PR do?

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update

Tests Performed

Screenshots

Additional Comments

jinyoungbang and others added 22 commits October 15, 2023 21:44
@jinyoungbang
feat: implement ses modules and boilerplate code
9ba98e8
@jinyoungbang
chore: add TODOs for announcements route
b85294a
implemented basic email send from vault:users in Mongo + updated Pipf…
d15f596 
…ile w/ pymongo[srv]
implemented broadcast route and mongo service + update Pipfiles
1971a82
@jinyoungbang
Merge pull request #8 from whyphi/staging
ea0deaa 
Merge: `staging` to `main`
@jinyoungbang
Merge pull request #16 from whyphi/staging
0a53a58 
Merge: staging to main
announcements route now accepts subject & content from frontend
ababd8f
@jinyoungbang
fix: fix merge conflict
8715ce8
@jinyoungbang
fix: merge dev/v0.2 to branch
21255de
@jinyoungbang
fix: fix merge conflict on announcments
fb1bfa6
@jinyoungbang
refactor: put form application API to ListingService
27f3002
@jinyoungbang
chore: add TODOs on form submission validation strategy
9f3c3fe
restructuring- resolving comments from JYB's review
35f7c64
@jinyoungbang
Merge branch 'dev/v0.2' into feat/ses-announcements
9b70563
@jinyoungbang
Merge pull request #9 from whyphi/feat/ses-announcements
3313e69 
feat: Implement Mass Announcement Features through AWS SES
@jinyoungbang
Merge remote-tracking branch 'origin' into feat/form-email-confirmation
adcf5ef
@jinyoungbang
chore: merging
0afc147
@jinyoungbang
refactor: style
5279433
@jinyoungbang
feat: implement email confirmation feature
a040cab
@jinyoungbang
refactor: use instance instead of initialization
22e999f
@jinyoungbang
Merge pull request #24 from whyphi/feat/form-email-confirmation
21d9497 
feat: Email Confirmation for Application
@jinyoungbang
fix: grammar
afec00e
@github-actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
727 613 84% 80% 🟢

New Files

File Coverage Status
chalicelib/api/announcements.py 40% 🟢
chalicelib/blueprints/init.py 100% 🟢
chalicelib/modules/mongo.py 40% 🟢
chalicelib/modules/ses.py 40% 🟢
TOTAL 55% 🟢

Modified Files

File Coverage Status
app.py 100% 🟢
chalicelib/api/listings.py 86% 🟢
chalicelib/s3.py 52% 🟢
chalicelib/services/ListingService.py 83% 🟢
tests/api/test_listings.py 100% 🟢
tests/services/test_listing_service.py 100% 🟢
tests/test_app.py 100% 🟢
TOTAL 89% 🟢

updated for commit: 5cd5f84 by action🐍

@jinyoungbang jinyoungbang marked this pull request as ready for review January 23, 2024 14:28
@jinyoungbang jinyoungbang merged commit df40a92 into staging Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinyoungbang @cwgough