Feat/data analytics (code refactor) #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice to send dashboard analytics
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
…ion SMH bruh bruh bruh
…test_insights_service
jinyoungbang
requested changes
Feb 15, 2024
Contributor
jinyoungbang
left a comment
There was a problem hiding this comment.
LGTM! Just two minor changes:
- Can you switch camel case to snake case? https://www.pluralsight.com/blog/software-development/programming-naming-conventions-explained
- Make sure you create a test case to handle your exception
… updated unit-tests
jinyoungbang
approved these changes
Feb 16, 2024
Contributor
jinyoungbang
left a comment
There was a problem hiding this comment.
LGTM! Added a minor comment but not necessary to change haha
| common_grad_year, count_common_grad_year = "", 0 | ||
|
|
||
| # update most common major | ||
| for major, freq in majors.items(): |
Contributor
There was a problem hiding this comment.
some cool tips: max(data.items(), key=lambda x: x[1])
you could do something like this and manipulate this data to get the maximum/most common item of a dictionary! (a simple one liner)
Member
Author
There was a problem hiding this comment.
dang, man's pulled out the lambda funcion 😂
Member
Author
There was a problem hiding this comment.
damn that actually just cut like 15 lines of code lmaoooo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Created an InsightsService and corresponding API endpoint to perform all data analysis in the backend. Kept a similar code structure to the frontend code, but added some additional checks for null/empty values.
Type of change
Tests Performed
Planning to experiment with some unit tests, but for now just tested directly using a new listing "Big Data"
UPDATE: completed unit tests for both
apiandInsightsServiceScreenshots
https://drive.google.com/file/d/1f6k0tTP6ERyQY8Ddyw2hNDcYdDwC7Qc6/view?usp=sharing
Additional Comments