Refactor: Adding static and dynamic metadata#47
Merged
jinyoungbang merged 4 commits intodev/v0.2from Jan 28, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now, the metadata of most pages shows only the link. This work-in-progress feature aims to add a static metadata to every available pages in why-phi.
One issue is that we are passing client components to our pages which Next.js would prevent us from adding our own metadata. Following this solution, I will have to find a way to separate the client components from
layout.tsx.Type of change
Tests Performed
Screenshots
Additional Comments