feat: Data Analytics Dashboard on a Listing #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicants for given listingId)
update "feat/data-analytics" branch with upstream code from "dev/0.2
…icants for those metrics
jinyoungbang
approved these changes
Jan 12, 2024
Contributor
jinyoungbang
left a comment
There was a problem hiding this comment.
Apart from UI/UX issues, I think this feature is solid and functional – overall, amazing job and LGTM! Feel free to merge the PR yourself since it'd be cool for you to leave a mark @wderocco8
We can work on how to best refactor this page and add other features later on or as an extension!
Contributor
There was a problem hiding this comment.
Lovely – I was actually planning to do this for refactoring but this will make organizing code so much more easily!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the initial draft of a data analytics feature that is linked to each ListingCard. It enables users to visualize the distribution of key metrics for PCT applicants (e.g.
gpa,major,minor,class...) usingrechartspie charts. This branch requires an additional dependency (recharts), so be sure to runnpm installin theportaldirectory in order to use this feature.Type of change
Tests Performed
So far, only some basic preliminary tests have been performed, but they appear to be successful. To test for yourself:
Listingor use an old one (be sure that the listing is populated with applicants)settingsicon on the lisitnginsightsScreenshots
Additional Comments
hehe my first PR draft 👹