Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#933 Use Webjars for JQuery UI themes#934

Closed
mcr-paulanand wants to merge 1 commit intowicketstuff:masterfrom
mcr-paulanand:refactoring/#933-Use-Webjars-for-JQuery-UI-themes
Closed

#933 Use Webjars for JQuery UI themes#934
mcr-paulanand wants to merge 1 commit intowicketstuff:masterfrom
mcr-paulanand:refactoring/#933-Use-Webjars-for-JQuery-UI-themes

Conversation

@mcr-paulanand
Copy link
Contributor

Resolves #933

@solomax
Copy link
Contributor

solomax commented Jun 7, 2024

I believe this PR should be closed and shouldn't be merged

you are replacing customized themed CSS with the default one ...

this will effectively ruin theming :(

@reckart
Copy link
Contributor

reckart commented Jun 7, 2024

The Webjars install in this PR seems to be essential for me, otherwise my app won't start (i.e. with the 10.1.0 release, it won't start).

@solomax
Copy link
Contributor

solomax commented Jun 7, 2024

@reckart I believe you need to add 'install' to your app's 'init'

I'll try to check this branch locally and will report back

@reckart
Copy link
Contributor

reckart commented Jun 7, 2024

The init method runs after the SPI-injected initializers and the theme initializer already triggers a webjar access.

@solomax
Copy link
Contributor

solomax commented Jun 7, 2024

The init method runs after the SPI-injected initializers and the theme initializer already triggers a webjar access.

I did some testing:

  • clone repo for this PR

  • build 51 subproject of wicket-jquery-ui

  • cd wicketstuff-jquery-ui-samples

  • change the theme to be wicketstuff-jquery-ui-theme-eggplant

  • run samples
    Result: theme remain the same

  • Tested the release with the same steps
    Result: Samples were not started

My conclusion: WicketWebjars.install((WebApplication)application); MUST be added to all Initializers

This PR: shouldn't be merged as-is ...

New release seems to be required :(

@solomax
Copy link
Contributor

solomax commented Jun 7, 2024

I can create alternative pr for review later today :)

@solomax
Copy link
Contributor

solomax commented Jun 7, 2024

I can create alternative pr for review later today :)

Done: #935 :)))

@reckart
Copy link
Contributor

reckart commented Jun 7, 2024

Ok, so we can close this one. Thanks @mcr-paulanand @solomax !

@reckart reckart closed this Jun 7, 2024
@reckart reckart reopened this Jun 7, 2024
@reckart reckart closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error during startup when using a non-default theme

3 participants