#933 Use Webjars for JQuery UI themes#934
#933 Use Webjars for JQuery UI themes#934mcr-paulanand wants to merge 1 commit intowicketstuff:masterfrom
Conversation
|
I believe this PR should be closed and shouldn't be merged you are replacing customized themed CSS with the default one ... this will effectively ruin theming :( |
|
The Webjars install in this PR seems to be essential for me, otherwise my app won't start (i.e. with the 10.1.0 release, it won't start). |
|
@reckart I believe you need to add 'install' to your app's 'init' I'll try to check this branch locally and will report back |
|
The init method runs after the SPI-injected initializers and the theme initializer already triggers a webjar access. |
I did some testing:
My conclusion: This PR: shouldn't be merged as-is ... New release seems to be required :( |
|
I can create alternative pr for review later today :) |
Done: #935 :))) |
|
Ok, so we can close this one. Thanks @mcr-paulanand @solomax ! |
Resolves #933