Fix favicon property, add apple-mobile-web-app-title #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your submission! This repo uses atomic commits with sentence case. Would you please separate the changes into their own commits?
It would be useful to explain what is being fixed. Perhaps "Use correct sizes for favicon-96x96.png icon link"?
I'm unfamiliar with this one, so specifying that it's a meta would be helpful. Perhaps "Add apple-mobile-web-app-title meta"? I think the new meta belongs in partials/paige/metas.html, just below the charset meta line, with a blank line between it and the following template code. |
It specifies a title for homescreen bookmarks.
|
@flyingflo Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking the metadata with realfavicongenerator I found those little issues.