pre-commit hook compliance iteration (some automated, some manual) #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, that's useful and informative. Before spending effort resolving these new conflicts maybe wait a while in case #871 receives change requests and/or #856 progresses. Some of these fixes are also present there and testing both #871 and #856 requires some extra care and thought. Also I see the automated testing is having a think: I suspect at least that will be trivial. |
bc02107 to
6ec49ff
Compare
6ec49ff to
a68dbed
Compare
a68dbed to
211ca21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bringing the code to compliance following #871