fixes #8 #15
fixes #8 #15
Conversation
The side effect of this PR, is that `/\<$SEARCH\` `/?<$SEARCH\` will get echoed every time `n` or `N` are pressed. As this is the default neovim (and maybe vim) behavior + that it isn't stated in https://github.com/wincent/loupe#overrides. I don't thinks this change in behavior matters. Having the search indices matches neovim defaults.
|
@wincent friendly ping! |
|
Friendly ping. Got any feedback on this PR? Thanks. |
|
The code seems fine @pchampio, but I am struggling to see what actually changes as a result of this PR, at least with the versions of Vim and Neovim that I am testing:
In Vim I don't see the search indices, in Neovim I do ( |
|
What am I supposed to be seeing here?
|
|
My first tests were pretty pointless because I forgot that I had the Loupe mappings disabled like this in my Anyway, when I re-enable them, I can't seem to get this PR to work. On Neovim (NVIM v0.5.0-5d5b068) I see the search indices, but they never update: On Vim, I don't see the indices, except for a brief flash at the start (ie. if I type |
|
Using the following " Leader Mappings
let mapleader = ","
" Add bundles
call plug#begin('/tmp/')
" searching
Plug 'pchampio/loupe'
map <leader><space> <Plug>(LoupeClearHighlight)
call plug#end()On both vim and Neovim, I see the search indices, and they update. I confirm that this PR was needed on neovim in order to have the search indices. |
Fixes: #8
The side effect of this PR, is that
/\<$SEARCH\/?<$SEARCH\will get echoed every time a loupe mapping gets called.
As this is the default neovim (and maybe vim) behavior + that it isn't
stated in https://github.com/wincent/loupe#overrides.
I don't thinks this change in behavior matters.
Having the search indices matches neovim defaults matters much more.