Replace last search without manually deleting MagicString #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Please feel free to phrase things properly. I am not sure I could express it properly in the documentation. |
Owner
|
Thanks. Doesn't look too bad to me. I'm going to take it for a test-drive. |
When having `set g:LoupeVeryMagicReplace=1` the magic string `\v` will be deleted automatically when leaving the search field empty in search & replace. This is useful, because it will automatically replace the last search
Owner
|
Was that just a straight-up rebase @miallo with no changes? |
wincent
reviewed
Jan 5, 2023
Co-authored-by: wincent <[email protected]>
Co-authored-by: wincent <[email protected]>
Author
Yes - sorry, I did not notice that this PR was from my master branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is the PR for #17.
At least from my tests, this seemes to work as expected. I am not 100% satisfied with the name of the flag (
g:LoupeVeryMagicReplace) and of course I would also add some documentation if this PR was accepted otherwise.Is this the way to go? Did I make any mistakes with the implementation?
Thanks a lot for your awesome videos and plugins!