Add API to close Wayland windows on shutdown #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can split up the implementation in the future for different windowing systems.
This allows Plasma to gracefully close windows on shutdown. For now this is only a stub in order to provide compatibility. We require logic similar to [1] in order to wait on windows closing and react to user input. But this includes many KDE dependencies into our windowing code what we first might want to isolate some more. [1] https://invent.kde.org/plasma/kwin/-/commit/4cdf27e74c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Plasma to gracefully close windows on shutdown. For now this is only a stub in order to provide compatibility. We require logic similar to this in order to wait on windows closing and react to user input. But this includes many KDE dependencies into our windowing code what we first might want to isolate some more.