Separate screen locker #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unused.
The description field is wrong. This unexpectedly also fixes the test-wl run when doing a release build.
This allows external reuse.
The Wayland specific base header should not be included in the generic render library part.
This removes the hard dependency on it in X11. BREAKING CHANGE: consumer creates screen locker for desktop platform
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 51.02% 50.37% -0.66%
==========================================
Files 938 941 +3
Lines 87395 87404 +9
Branches 45013 45460 +447
==========================================
- Hits 44593 44026 -567
- Misses 38238 39427 +1189
+ Partials 4564 3951 -613 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screen locker is only relevant on Wayland and only with KDE setup. This is a breaking change, as consumers need to update their setup code for the server.