Build fix #26
Merged
Build fix #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version of clang now checks for that. Ignore the error like with gcc.
After breaking change in Wrapland.
Starting with 0.18 wlroots package is versioned, see [1]. [1] https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/4b4f76cc13
New clang version comes with clang-format breaking changes.
Without this the script always has exit code 0.
The QPointer is marked by clang-tidy as use-after-free. We can listen for the delegate destruction instead manually with a connection.
On master branch we develop against the next wlroots version.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 50.78% 50.73% -0.05%
==========================================
Files 939 939
Lines 87348 87397 +49
Branches 45514 45110 -404
==========================================
- Hits 44356 44343 -13
+ Misses 39514 38022 -1492
- Partials 3478 5032 +1554 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to Wrapland and wlroots changes. Fix clang-tidy CI run.