Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@romangg
Copy link
Member

@romangg romangg commented Feb 18, 2024

  • Less compile warnings
  • Improve readme, add feature table for Wayland

These are not needed and produce warnings.
With wlroots and libwayland this warning is triggered at too many places. Still
it might make sense instead to enable the warning in general and disable it in
a more targetted manner with pragmas. For now we opt for the general removal
and add a todo comment to revisit later.
Produces a lot of warnings with gcc and potentially clang on structs where we
default-initialize some fields.
Produced compile warnings.
Taking the distance between the pointers is wrong. A warning on the for-loop
number types indicated this issue.
The desktop numbers are unsinged, so cast to int before comparing to zero.
They were declared but not defined.
The keyboard and by that the device files are referenced in X11 too.
Otherwise might not compile with sanitizers enabled.
The unique connection can give a runtime exception, likely because of the
multi-inheritance, what seems to be a bug in Qt.

Since it's not needed here actually, we just remove it.
This makes it easy to compile with sanitizers. For example like this:

    ECM_ENABLE_SANITIZERS='address;leak;undefined'
The old name has been deprecated.
The base variable is declared after qobject.
There is a warning comparing the raw strings.
These properties don't seem to be used, but they should still have different
names. Otehrwise a warning by Qt moc is issued.
Silences a GCC warning.
Silences a GCC warning.
Silences a GCC warning.
We don't use these functions internally and the call to XKeycodeToKeysym
produces a deprecation warning.

Before trying to fix the warning, we may simply remove the unused functions.
@romangg romangg changed the title Small fixes to code and docs Various fixes to code and docs Feb 19, 2024
@romangg
Copy link
Member Author

romangg commented Feb 19, 2024

Also now installs Wrapland via CI package.

@romangg romangg force-pushed the fixes branch 3 times, most recently from c53fca4 to 1e50572 Compare February 20, 2024 11:31
Small changes to the text.
Provides an overview of already available and planned features in the Wayland
session.
There is a Matrix room now.
This makes the code more generic. Being used this way in Wrapland too.
Instead of using the separate CI image, install Wrapland from the latest
package artifact, that Wrapland's actions provide.
@romangg romangg merged commit 453f9ee into winft:master Feb 20, 2024
@romangg romangg deleted the fixes branch February 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant