-
-
Notifications
You must be signed in to change notification settings - Fork 6
Various fixes to code and docs #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
romangg
commented
Feb 18, 2024
- Less compile warnings
- Improve readme, add feature table for Wayland
These are not needed and produce warnings.
With wlroots and libwayland this warning is triggered at too many places. Still it might make sense instead to enable the warning in general and disable it in a more targetted manner with pragmas. For now we opt for the general removal and add a todo comment to revisit later.
Produces a lot of warnings with gcc and potentially clang on structs where we default-initialize some fields.
Produced compile warnings.
Produced compile warnings.
Taking the distance between the pointers is wrong. A warning on the for-loop number types indicated this issue.
The desktop numbers are unsinged, so cast to int before comparing to zero.
They were declared but not defined.
The keyboard and by that the device files are referenced in X11 too.
Otherwise might not compile with sanitizers enabled.
The unique connection can give a runtime exception, likely because of the multi-inheritance, what seems to be a bug in Qt. Since it's not needed here actually, we just remove it.
This makes it easy to compile with sanitizers. For example like this:
ECM_ENABLE_SANITIZERS='address;leak;undefined'
The old name has been deprecated.
The base variable is declared after qobject.
There is a warning comparing the raw strings.
These properties don't seem to be used, but they should still have different names. Otehrwise a warning by Qt moc is issued.
Silences a GCC warning.
Silences a GCC warning.
Silences a GCC warning.
We don't use these functions internally and the call to XKeycodeToKeysym produces a deprecation warning. Before trying to fix the warning, we may simply remove the unused functions.
Member
Author
|
Also now installs Wrapland via CI package. |
c53fca4 to
1e50572
Compare
Small changes to the text.
Provides an overview of already available and planned features in the Wayland session.
There is a Matrix room now.
This makes the code more generic. Being used this way in Wrapland too.
Instead of using the separate CI image, install Wrapland from the latest package artifact, that Wrapland's actions provide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.