Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(sdk): fewer replacements for cloud.Service and sim.Resource #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2024
Merged

feat(sdk): fewer replacements for cloud.Service and sim.Resource #6612

merged 6 commits into from
Jun 3, 2024

Conversation

@Chriscbr
Copy link
Contributor

Extends the changes made in #6577 for reducing the time it takes for the simulator to update to cloud.Service and sim.Resource.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from eladb May 31, 2024 22:08
@Chriscbr Chriscbr requested a review from a team as a code owner May 31, 2024 22:08
@github-actions
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented May 31, 2024 •
edited
Loading

Console preview environment is available at https://wing-console-pr-6612.fly.dev 🚀

Last Updated (UTC) 2024-06-03 04:02

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜🟥⬜⬜⬜🟥⬜⬜⬜
Benchmark Before After Change
version 60ms±0.53 60ms±1.2 +0ms (+0.8%)⬜
functions_10.test.w -t sim 530ms±22.41 517ms±8.2 -12ms (-2.32%)⬜
functions_10.test.w -t tf-aws 2144ms±17.66 2148ms±18.44 +5ms (+0.22%)⬜
hello_world.test.w -t sim 423ms±4.89 426ms±7.77 +4ms (+0.89%)⬜
hello_world.test.w -t tf-aws 1518ms±8.23 1517ms±8.6 -1ms (-0.07%)⬜
functions_1.test.w -t sim 415ms±6.09 429ms±7.45 +14ms (+3.36%)🟥
functions_1.test.w -t tf-aws 871ms±9.47 861ms±5.72 -9ms (-1.09%)⬜
jsii_big.test.w -t sim 2905ms±12.54 2898ms±13.27 -7ms (-0.25%)⬜
jsii_big.test.w -t tf-aws 3123ms±15.18 3130ms±10.8 +8ms (+0.24%)⬜
empty.test.w -t sim 379ms±5.21 391ms±5.02 +12ms (+3.04%)🟥
empty.test.w -t tf-aws 618ms±3.03 622ms±3.31 +4ms (+0.72%)⬜
jsii_small.test.w -t sim 388ms±5.1 397ms±3.76 +9ms (+2.27%)⬜
jsii_small.test.w -t tf-aws 636ms±6.2 644ms±6.32 +8ms (+1.26%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 59ms 64ms 1ms 2ms
functions_10.test.w -t sim 517ms 497ms 532ms 8ms 11ms
functions_10.test.w -t tf-aws 2148ms 2108ms 2183ms 18ms 26ms
hello_world.test.w -t sim 426ms 409ms 440ms 8ms 11ms
hello_world.test.w -t tf-aws 1517ms 1501ms 1536ms 9ms 12ms
functions_1.test.w -t sim 429ms 412ms 445ms 7ms 10ms
functions_1.test.w -t tf-aws 861ms 846ms 873ms 6ms 8ms
jsii_big.test.w -t sim 2898ms 2874ms 2938ms 13ms 19ms
jsii_big.test.w -t tf-aws 3130ms 3106ms 3160ms 11ms 15ms
empty.test.w -t sim 391ms 376ms 398ms 5ms 7ms
empty.test.w -t tf-aws 622ms 616ms 629ms 3ms 5ms
jsii_small.test.w -t sim 397ms 391ms 407ms 4ms 5ms
jsii_small.test.w -t tf-aws 644ms 628ms 660ms 6ms 9ms
Last Updated (UTC) 2024-05-31 22:20

eladb
eladb approved these changes Jun 1, 2024
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/cache-more is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 8342ebb into main Jun 3, 2024
@mergify mergify bot deleted the rybickic/cache-more branch June 3, 2024 04:08
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.74.33.

eladb pushed a commit that referenced this pull request Jun 6, 2024
@Chriscbr @eladb
feat(sdk): fewer replacements for cloud.Service and sim.Resource (#6612)
fb43db8 
Extends the changes made in #6577 for reducing the time it takes for the simulator to update to cloud.Service and sim.Resource.

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladb eladb eladb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chriscbr @monadabot @eladb